feat: support TaxItem alongside Tax after pricing-client bump - #289
Merged
Conversation
Bumps @epilot/pricing-client to ^3.55.1, which introduced TaxItem: an ad-hoc tax rate with no backing entity, for custom/composite line items with no product or price reference to resolve tax from. Widens every tax parameter/return type from Tax to Tax | TaxItem across the computation chain. TaxItem has no _id (by design — it isn't persisted and can't be deduplicated by identity), which compute-totals.ts's tax-bucket aggregation previously assumed always existed. Added a small getTaxId() helper that only reads _id when present, instead of widening _id itself into an unsafe optional everywhere. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: ecc5e54 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps @epilot/pricing-client to ^3.55.1, which introduced TaxItem: an ad-hoc tax rate with no backing entity, for custom/composite line items with no product or price reference to resolve tax from. Widens every tax parameter/return type from Tax to Tax | TaxItem across the computation chain.
TaxItem has no _id (by design — it isn't persisted and can't be deduplicated by identity), which compute-totals.ts's tax-bucket aggregation previously assumed always existed. Added a small getTaxId() helper that only reads _id when present, instead of widening _id itself into an unsafe optional everywhere.